pgaref commented on a change in pull request #2300:
URL: https://github.com/apache/hive/pull/2300#discussion_r635901296
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastBytesHashKeyRef.java
##########
@@ -69,12 +69,14 @@ public static int calculateHashCode(long refWord,
WriteBuffers writeBuffers,
// And, if current value is big we must read it.
actualKeyLength = writeBuffers.readVInt(readPos);
- keyAbsoluteOffset = absoluteOffset + actualKeyLength;
+
+ // Now the read position is set to start of the key as readVInt moved the
+ // position by size of key length.
+ return writeBuffers.hashCode(actualKeyLength, readPos);
Review comment:
I guess the fact that we have perform a read to get the actual KeyLen is
making things more complex here.
Shall we add some comments on them method level for future ref?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
