pvary commented on a change in pull request #2266:
URL: https://github.com/apache/hive/pull/2266#discussion_r636828134



##########
File path: ql/src/test/queries/clientpositive/columnstats_partlvl_dp.q
##########
@@ -70,3 +70,9 @@ describe formatted Employee_n0 partition 
(employeeSalary='6000.0', country='UK')
 describe formatted Employee_n0 partition (employeeSalary='6000.0', 
country='UK') c;
 describe formatted Employee_n0 partition (employeeSalary='6000.0', 
country='UK') d;
 
+analyze table Employee_n0 partition (employeeSalary,country) compute 
statistics for columns;
+
+describe formatted Employee_n0 partition (employeeSalary='6000.0', 
country='UK') employeeName;
+describe formatted Employee_n0 partition (employeeSalary='6000.0', 
country='UK') c;
+describe formatted Employee_n0 partition (employeeSalary='6000.0', 
country='UK') d;

Review comment:
       We might want to add tests where we insert different data into 
partitions where only the letter cases are different to check the results, like 
`country='UK'` and `country='uK'`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to