pvary commented on a change in pull request #2261:
URL: https://github.com/apache/hive/pull/2261#discussion_r636872733
##########
File path:
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/Catalogs.java
##########
@@ -97,13 +97,13 @@ public static Table loadTable(Configuration conf,
Properties props) {
props.getProperty(InputFormatConfig.CATALOG_NAME));
}
- private static Table loadTable(Configuration conf, String tableIdentifier,
String tableLocation,
- String catalogName) {
+ private static Table loadTable(Configuration conf, String tableIdentifier,
String tableLocation, String catalogName) {
Optional<Catalog> catalog = loadCatalog(conf, catalogName);
if (catalog.isPresent()) {
Preconditions.checkArgument(tableIdentifier != null, "Table identifier
not set");
- return catalog.get().loadTable(TableIdentifier.parse(tableIdentifier));
+ Table table =
catalog.get().loadTable(TableIdentifier.parse(tableIdentifier));
Review comment:
Is this change needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
