maheshk114 commented on a change in pull request #2308:
URL: https://github.com/apache/hive/pull/2308#discussion_r638695764
##########
File path:
storage-api/src/java/org/apache/hadoop/hive/common/type/FastHiveDecimalImpl.java
##########
@@ -273,7 +269,8 @@ public static boolean fastSetFromBytes(byte[] bytes, int
offset, int length, boo
int index = offset;
if (trimBlanks) {
- while (bytes[index] == BYTE_BLANK) {
+ //Character.isWhitespace handles both space and tab character
Review comment:
isWhitespace covers many more things like PARAGRAPH_SEPARATOR,
LINE_SEPARATOR. How is the behaviour of other databases like postgres for that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
