pgaref commented on a change in pull request #2224:
URL: https://github.com/apache/hive/pull/2224#discussion_r638805823
##########
File path:
llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java
##########
@@ -1168,16 +1165,13 @@ public void allocateTask(Object task, Resource
capability, ContainerId container
capability, null, null, clock.getTime(), id);
LOG.info("Received allocateRequest. task={}, priority={}, capability={},
containerId={}",
task, priority, capability, containerId);
- writeLock.lock();
- try {
- if (!dagRunning && metrics != null && id != null) {
+ if (!dagRunning) {
+ if (metrics != null && id != null) {
Review comment:
Thanks for checking this out Mahesh, I guess this behaviour was already
existing -- what changed in this PR is avoiding the writeLock for dagRunning.
Since now metrics like **numRequestedAllocations** and
**numRequestsWithLocation** are Atomic* the writelock can be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
