lcspinter commented on a change in pull request #2261:
URL: https://github.com/apache/hive/pull/2261#discussion_r639093469
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/Driver.java
##########
@@ -213,7 +216,14 @@ private void runInternal(String command, boolean
alreadyCompiled) throws Command
releaseResources();
}
+ if (SessionState.get() != null) {
+ // Clean up every resource object stored in the query state
+ driverContext.getQueryState().removeResources();
Review comment:
I think we need it. We have an instance of `QueryState` stored on the
`DriverContext`, and we have the same `QueryState` instance stored on
`SessionState` as well. If I remove the `QueryState` just from the
`SessionState`, we will end up with some dangling resources on the `QueryState`
bound to the `DriverContext`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
