belugabehr commented on a change in pull request #2312:
URL: https://github.com/apache/hive/pull/2312#discussion_r639715427
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/cache/results/QueryResultsCache.java
##########
@@ -860,15 +804,10 @@ public static void cleanupInstance() {
}
}
- private static ScheduledExecutorService invalidationExecutor = null;
- private static ExecutorService deletionExecutor = null;
-
- static {
- ThreadFactory threadFactory =
- new
ThreadFactoryBuilder().setDaemon(true).setNameFormat("QueryResultsCache
%d").build();
- invalidationExecutor =
Executors.newSingleThreadScheduledExecutor(threadFactory);
- deletionExecutor = Executors.newSingleThreadExecutor(threadFactory);
- }
+ private static ScheduledExecutorService invalidationExecutor =
Executors.newSingleThreadScheduledExecutor(
+ new
ThreadFactoryBuilder().setDaemon(true).setNameFormat("QueryCacheInvalidator
%d").build());
+ private static ExecutorService deletionExecutor =
Executors.newSingleThreadScheduledExecutor(
+ new
ThreadFactoryBuilder().setDaemon(true).setNameFormat("QueryCacheDeletor
%d").build());
Review comment:
Re-factor and give each pool its own name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]