oleksiy-sayankin commented on a change in pull request #2323:
URL: https://github.com/apache/hive/pull/2323#discussion_r640409691
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
##########
@@ -5269,6 +5293,32 @@ private void preDropStorageDescriptor(MStorageDescriptor
msd) {
removeUnusedColumnDescriptor(mcd);
}
+ /**
+ * Get a list of storage descriptors that reference a particular Column
Descriptor
+ * @param oldCD the column descriptor to get storage descriptors for
+ * @return a list of storage descriptors
+ */
+ private List<MStorageDescriptor>
listStorageDescriptorsWithCD(MColumnDescriptor oldCD, Query query) {
+ boolean success = false;
+ List<MStorageDescriptor> sds = null;
+ try {
+ openTransaction();
Review comment:
And what do you think of method _listStorageDescriptorsWithCD_? It also
uses open/commit transaction and If I implement open/commit transaction in
_removeUnusedColumnDescriptor()_ it seems to be like this
removeUnusedColumnDescriptor(){
openTransaction()
if (isPostgres()) {
listStorageDescriptorsWithCD {
openTransaction() <--- do we need this?
1. SELECT * FROM "SDS" "A0" WHERE "A0"."CD_ID" = $1 limit 1)
commitTransaction() <--- do we need this?
}
} else {
2. select count(1) from
org.apache.hadoop.hive.metastore.model.MStorageDescriptor where (this.cd ==
inCD)
}
3. pm.deletePersistentAll(mConstraintsList);
4. pm.deletePersistent(oldCD);
commitTransaction()
}
so open/commit transaction inside _listStorageDescriptorsWithCD()_ is
redundant. Agree?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
