pvary commented on a change in pull request #2316:
URL: https://github.com/apache/hive/pull/2316#discussion_r642557681
##########
File path:
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergSerDe.java
##########
@@ -115,7 +123,9 @@ public void initialize(@Nullable Configuration
configuration, Properties serDePr
// create table for CTAS
if (e instanceof NoSuchTableException &&
Boolean.parseBoolean(serDeProperties.getProperty(hive_metastoreConstants.TABLE_IS_CTAS)))
{
- LOG.info("Creating table {} for CTAS with schema: {}",
serDeProperties.get(Catalogs.NAME), tableSchema);
+ if (!Catalogs.hiveCatalog(configuration, serDeProperties)) {
+ throw new SerDeException(CTAS_EXCEPTION_MSG);
+ }
Review comment:
nit: newline after end of the block
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
