deniskuzZ commented on pull request #2266: URL: https://github.com/apache/hive/pull/2266#issuecomment-851905628
> > NOTE: I don't think TxnHandler is a good place for this kind of functionality. TxnHandler is responsible for managing txn metadata ONLY!! Wouldn't MetaStoreDirectSql be more appropriate here? @pvary what do you think? > > The MetaStoreDirectSql does not have framework to handle adding notification logs within same transaction. That can cause issues in replication if the notification logs addition fails because of some reason. The MetaStoreDirectSql batch insert/update also not very performant. What I meant here is that TxnHandler shouldn't have colStats update logic, it's responsible for other functionality like Hive TXN management. HiveMetaStore can handle notification logs, what about it? Or if we can't find close by functionality service - we should create a new one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
