lcspinter commented on a change in pull request #2333:
URL: https://github.com/apache/hive/pull/2333#discussion_r643758291
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
##########
@@ -13455,6 +13469,18 @@ ASTNode analyzeCreateTable(
}
}
+ if (partitionTransformSpecExists) {
+ try {
+ HiveStorageHandler storageHandler = HiveUtils.getStorageHandler(conf,
storageFormat.getStorageHandler());
Review comment:
We need to parse all the tokens in the AST Tree before we can make any
validation.
If we have a query like this
`CREATE EXTERNAL TABLE ... PARTITIONED BY SPEC (....) STORED BY ICEBERG`,
the tokens are processed in order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
