pgaref commented on a change in pull request #2264:
URL: https://github.com/apache/hive/pull/2264#discussion_r646550206
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java
##########
@@ -281,16 +285,23 @@ private VectorizedOrcAcidRowBatchReader(JobConf conf,
OrcSplit orcSplit, Reporte
deleteEventReaderOptions.range(0, Long.MAX_VALUE);
deleteEventReaderOptions.searchArgument(null, null);
keyInterval = findMinMaxKeys(orcSplit, conf, deleteEventReaderOptions);
+ fetchDeletedRows = conf.getBoolean(Constants.ACID_FETCH_DELETED_ROWS,
false);
DeleteEventRegistry der;
try {
// See if we can load all the relevant delete events from all the
// delete deltas in memory...
+ ColumnizedDeleteEventRegistry.OriginalWriteIdLoader writeIdLoader;
+ if (fetchDeletedRows) {
+ writeIdLoader = new ColumnizedDeleteEventRegistry.BothWriteIdLoader();
Review comment:
Maybe rename to something more explicit like
OriginalAndCurrentWriteIdLoader?
Also lets add some comment above explaining the logic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
