pgaref commented on a change in pull request #2264:
URL: https://github.com/apache/hive/pull/2264#discussion_r646602703
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java
##########
@@ -2039,4 +2189,29 @@ private static IntegerColumnStatistics
deserializeIntColumnStatistics(List<OrcPr
deserializeIntColumnStatistics(colStats, OrcRecordUpdater.ROW_ID + 1);
return getKeyInterval(columnStatsArray);
}
+
+ private static class RowIsDeletedColumnVector extends LongColumnVector {
+ void clear() {
+ Arrays.fill(vector, 0);
Review comment:
Believe reset() method is a better choise, especially as we set repeat
flag below
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java
##########
@@ -2039,4 +2189,29 @@ private static IntegerColumnStatistics
deserializeIntColumnStatistics(List<OrcPr
deserializeIntColumnStatistics(colStats, OrcRecordUpdater.ROW_ID + 1);
return getKeyInterval(columnStatsArray);
}
+
+ private static class RowIsDeletedColumnVector extends LongColumnVector {
+ void clear() {
+ Arrays.fill(vector, 0);
Review comment:
Believe reset() method is a better choice here, especially as we set
repeat flag below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
