pvary commented on a change in pull request #2376:
URL: https://github.com/apache/hive/pull/2376#discussion_r648697220
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java
##########
@@ -9037,8 +9061,16 @@ public boolean
set_aggr_stats_for(SetPartitionsStatsRequest request) throws TExc
} else { // No merge.
Table t = getTable(catName, dbName, tableName);
// We don't short-circuit on errors here anymore. That can leave acid
stats invalid.
- ret = updatePartitionColStatsInBatch(t, newStatsMap,
- request.getValidWriteIdList(), request.getWriteId());
+ if (MetastoreConf.getBoolVar(getConf(), ConfVars.TRY_DIRECT_SQL)) {
Review comment:
It is very strange to use the `ConfVars.TRY_DIRECT_SQL` configuration in
client side.
We could have used the same patterns like in `get_table_statistics_req`:
- HMSHandler has only a single method to call on `getMS()`
- ObjectStore could use some `GetHelper` implementation to decide on the
actual implementation (directsql/datanucleus)
- If we want to make sure that the size of the Thrift request is not too
much we might have another configuration on client size like we do with
`BATCH_RETRIEVE_MAX`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
