aasha commented on a change in pull request #2320:
URL: https://github.com/apache/hive/pull/2320#discussion_r650646490
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java
##########
@@ -517,9 +517,9 @@ private static ImportTableDesc
getBaseCreateTableDescFromTable(String dbName,
}
private static Task<?> createTableTask(ImportTableDesc tableDesc,
EximUtil.SemanticAnalyzerWrapperContext x,
- String dumpRoot,
ReplicationMetricCollector metricCollector) {
+ String dumpRoot,
ReplicationMetricCollector metricCollector, boolean e) {
Review comment:
rename to execute parallel
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/DDLTask.java
##########
@@ -117,6 +119,6 @@ public String getName() {
*/
@Override
public boolean canExecuteInParallel() {
- return false;
+ return work.isExecuteInParallel();
Review comment:
nit : rename to canExecuteInParallel?
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java
##########
@@ -555,7 +555,7 @@ private static ImportTableDesc
getBaseCreateTableDescFromTable(String dbName,
tableDesc.setReplicationSpec(replicationSpec);
}
return tableDesc.getCreateTableTask(x.getInputs(), x.getOutputs(),
x.getConf(), isReplication,
- dumpRoot, metricCollector);
Review comment:
write a test if possible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
