abstractdog opened a new pull request #2000:
URL: https://github.com/apache/hive/pull/2000
### What changes were proposed in this pull request?
I just wanted to own the 2000th PR so created this. :)
Btw, throwing an exception if the user tries to use bounded range window
without ORDER BY clause, similarly to Postgres.
the patch is basically only a check and throw:
```
if (windowFrame.getWindowType() == WindowType.RANGE
&& (windowFrame.getStart().isBoundedNotCurrent()
|| windowFrame.getEnd().isBoundedNotCurrent())) {
throw new SemanticException(
"RANGE with offset PRECEDING/FOLLOWING requires exactly one
ORDER BY column");
}
```
all other changes are only formatting...WindowingSpec class was in very bad
shape from formatting point of view, I think this was a good opportunity to
clean it
### Why are the changes needed?
Described in JIRA.
### Does this PR introduce _any_ user-facing change?
The exception in the mentioned use-case.
### How was this patch tested?
Manually and with a negative test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
