maheshk114 commented on a change in pull request #2365:
URL: https://github.com/apache/hive/pull/2365#discussion_r651886691
##########
File path:
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java
##########
@@ -905,25 +909,32 @@ public void
onUpdatePartitionColumnStat(UpdatePartitionColumnStatEvent updatePar
}
@Override
- public void
onUpdatePartitionColumnStatDirectSql(UpdatePartitionColumnStatEvent
updatePartColStatEvent,
- Connection dbConn,
SQLGenerator sqlGenerator)
+ public void
onUpdatePartitionColumnStatInBatch(UpdatePartitionColumnStatEventBatch
updatePartColStatEventBatch,
Review comment:
Yes ..for normal listeners we can not change as they may be expecting
the data in that way. The change is done only for transactional listeners
(DBNotification listener is a transactional listener). The notification for
transactional listeners are done inside the direct sql method as it has to be
within same transaction. For normal listeners we need not have them in the same
transaction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
