pkumarsinha commented on a change in pull request #2396:
URL: https://github.com/apache/hive/pull/2396#discussion_r655838555



##########
File path: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java
##########
@@ -1339,7 +1340,8 @@ public void commitTxn(CommitTxnRequest rqst)
             // corresponding open txn event.
             LOG.info("Target txn id is missing for source txn id : " + 
sourceTxnId +
                     " and repl policy " + rqst.getReplPolicy());
-            return;
+            throw new NoSuchTxnException("Source transaction: " + 
JavaUtils.txnIdToString(sourceTxnId)

Review comment:
       Aren't we aborting based on target txn id so we know which target txn id 
we are looking for?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to