kgyrtkirk commented on a change in pull request #2360:
URL: https://github.com/apache/hive/pull/2360#discussion_r655492864
##########
File path: ql/src/test/queries/clientpositive/select_sum.q
##########
@@ -0,0 +1,14 @@
+DROP DATABASE IF EXISTS db5 CASCADE;
+CREATE DATABASE db5;
+use db5;
+CREATE TABLE IF NOT EXISTS t1(c0 boolean, c1 boolean);
+
+SELECT SUM(1) FROM t1;
Review comment:
could you please add an explain to see the optimization in action?
##########
File path: ql/src/test/queries/clientpositive/select_sum.q
##########
@@ -0,0 +1,14 @@
+DROP DATABASE IF EXISTS db5 CASCADE;
+CREATE DATABASE db5;
+use db5;
Review comment:
these lines could be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
