pvary commented on a change in pull request #2413: URL: https://github.com/apache/hive/pull/2413#discussion_r655513679
########## File path: itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenariosAcidTables.java ########## @@ -74,7 +74,7 @@ /** * TestReplicationScenariosAcidTables - test replication for ACID tables. */ [email protected]("HIVE-25267") +//@org.junit.Ignore("HIVE-25267") Review comment: Does this fix the flakiness issue mentioned in HIVE-25267? ########## File path: itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenariosAcidTables.java ########## @@ -176,6 +177,28 @@ public void testReplOperationsNotCapturedInNotificationLog() throws Throwable { assert lastEventId == currentEventId; } + @Test + public void testREADOperationsNotCapturedInNotificationLog() throws Throwable { Review comment: nit: we should use camelcase for methods ########## File path: itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenariosAcidTables.java ########## @@ -176,6 +177,28 @@ public void testReplOperationsNotCapturedInNotificationLog() throws Throwable { assert lastEventId == currentEventId; } + @Test + public void testREADOperationsNotCapturedInNotificationLog() throws Throwable { + //Perform empty bootstrap dump and load + primary.hiveConf.set("hive.txn.readonly.enabled", "true"); + primary.run("create table " + primaryDbName + ".t1 (id int)"); + primary.dump(primaryDbName); + replica.run("REPL LOAD " + primaryDbName + " INTO " + replicatedDbName); + //Perform empty incremental dump and load so that all db level properties are altered. + primary.dump(primaryDbName); + replica.run("REPL LOAD " + primaryDbName + " INTO " + replicatedDbName); + primary.run("insert into " + primaryDbName + ".t1 values(1)"); + long lastEventId = primary.getCurrentNotificationEventId().getEventId(); + primary.run("DESCRIBE DATABASE " + primaryDbName ); + primary.run("SELECT * from " + primaryDbName + ".t1"); + primary.run("SHOW tables " + primaryDbName); Review comment: What is the reason behind running these commands but discarding the results? ########## File path: itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenariosAcidTables.java ########## @@ -176,6 +177,28 @@ public void testReplOperationsNotCapturedInNotificationLog() throws Throwable { assert lastEventId == currentEventId; } + @Test + public void testREADOperationsNotCapturedInNotificationLog() throws Throwable { + //Perform empty bootstrap dump and load + primary.hiveConf.set("hive.txn.readonly.enabled", "true"); + primary.run("create table " + primaryDbName + ".t1 (id int)"); + primary.dump(primaryDbName); + replica.run("REPL LOAD " + primaryDbName + " INTO " + replicatedDbName); + //Perform empty incremental dump and load so that all db level properties are altered. + primary.dump(primaryDbName); + replica.run("REPL LOAD " + primaryDbName + " INTO " + replicatedDbName); + primary.run("insert into " + primaryDbName + ".t1 values(1)"); + long lastEventId = primary.getCurrentNotificationEventId().getEventId(); + primary.run("DESCRIBE DATABASE " + primaryDbName ); + primary.run("SELECT * from " + primaryDbName + ".t1"); + primary.run("SHOW tables " + primaryDbName); Review comment: never mind, I got it 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
