kasakrisz commented on a change in pull request #2401:
URL: https://github.com/apache/hive/pull/2401#discussion_r657780988



##########
File path: 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveCalciteUtil.java
##########
@@ -1252,4 +1252,18 @@ public static ImmutableBitSet extractRefs(Aggregate 
aggregate) {
     }
     return refs.build();
   }
+
+  public static Set<RexTableInputRef> findRexTableInputRefs(RexNode rexNode) {

Review comment:
       `RexUtil.gatherTableReferences` returns `Set<RelTableRef>` and not 
Set<RexTableInputRef>. `RelTableRef` does not contains the index of this 
InputRef in the TS schema which is required to identify if the 
`RexTableInputRef` instance refers a partition column or not. 
`RelOptHiveTable.getPartColInfoMap()` contains the indexes not the instances.
   The RexTableInputRef index is also required by 
`HiveCardinalityPreservingJoinOptimization` that is why I extarcted 
`findRexTableInputRefs`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to