hsnusonic commented on a change in pull request #2457:
URL: https://github.com/apache/hive/pull/2457#discussion_r669819264
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java
##########
@@ -10447,4 +10447,22 @@ public void drop_package(DropPackageRequest request)
throws MetaException {
endFunction("drop_package", ex == null, ex);
}
}
+
+ @Override
+ public List<WriteEventInfo>
get_all_write_event_info(GetAllWriteEventInfoRequest request)
+ throws MetaException {
+ startFunction("get_all_write_event_info");
+ Exception ex = null;
+ try {
+ List<WriteEventInfo> writeEventInfoList =
+ getMS().getAllWriteEventInfo(request.getTxnId(),
request.getDbName(), request.getTableName());
+ return writeEventInfoList == null ? Collections.emptyList() :
writeEventInfoList;
+ } catch (Exception e) {
+ LOG.error("Caught exception", e);
+ ex = e;
Review comment:
`ex` is passed into `endFunction`. I guess the most obvious advantage is
to get the function audited so that we can get some metrics (time, counter).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
