kgyrtkirk commented on a change in pull request #2435:
URL: https://github.com/apache/hive/pull/2435#discussion_r670363826
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java
##########
@@ -374,9 +362,14 @@ public HMSHandler(String name, Configuration conf, boolean
init) throws MetaExce
}
}
}
- if (init) {
- init();
- }
+ }
+
+ @VisibleForTesting
+ public static HMSHandler getInitializedHandler(String name, Configuration
conf)
Review comment:
I don't understand why would we need this method - we already had the
`init` boolean trick
I think you are after making sure that all HMSHandler are initialized;
without the patch didn't you get NPE-s when you try to access databaseCount -
when the handler is not initialized?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
