hankfanchiu commented on a change in pull request #2484:
URL: https://github.com/apache/hive/pull/2484#discussion_r671413592
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
##########
@@ -4693,6 +4694,17 @@ private Table ensureGetTable(String catName, String
dbName, String tblName)
return convertToTable(ensureGetMTable(catName, dbName, tblName));
}
+ /**
+ * Conditionally alters an {@link ExpressionTree} to be compatible with
certain database products.
+ */
+ private void reconcileTreeWithDatabaseProduct(ExpressionTree tree) throws
MetaException {
+ if (sqlGenerator.getDbProduct().isDERBY()) {
Review comment:
@findepi mentioned in
https://issues.apache.org/jira/browse/HIVE-21614?focusedCommentId=16849571&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16849571
that Oracle may be implicated as well, but I have not verified.
Having this `ObjectStore#reconcileTreeWithDatabaseProduct` defined allows us
to conveniently add other databases, though, so perhaps we could revisit as
needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
