hmangla98 commented on a change in pull request #2121:
URL: https://github.com/apache/hive/pull/2121#discussion_r674418314
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java
##########
@@ -424,11 +518,13 @@ private boolean validDump(Path dumpDir) throws
IOException {
return false;
}
- private boolean shouldDump(Path previousDumpPath) throws IOException {
+ private boolean shouldDump(Path previousDumpPath, boolean
isPrevDumpFailoverReady) throws IOException {
//If no previous dump means bootstrap. So return true as there was no
//previous dump to load
if (previousDumpPath == null) {
return true;
+ } else if (isPrevDumpFailoverReady) {
+ return false;
Review comment:
Yes, in that case, it won't be treated as valid dump and execution would
go to getCurrentDumpPath to resume the previous failed dump.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
