kgyrtkirk commented on a change in pull request #2442:
URL: https://github.com/apache/hive/pull/2442#discussion_r674664805
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
##########
@@ -13137,13 +13136,12 @@ private void updateDefaultTblProps(Map<String,
String> source, Map<String, Strin
*
* @param tblProp
* property map
- * @param isCTAS
Review comment:
I've manually tested the patch; when the translator is enabled; running
```
create table b as select 1 aa
```
results in
```
Caused by: org.apache.hadoop.hive.metastore.api.MetaException: An external
table's location should not be located within managed warehouse root directory,
table:b,location:/data/hive/warehouse/b,managed warehou
se:/data/hive/warehouse
at
org.apache.hadoop.hive.metastore.MetastoreDefaultTransformer.validateTablePaths(MetastoreDefaultTransformer.java:932)
~[hive-exec-4.0.0-SNAPSHOT.jar:4.0.0-SNAPSHOT]
```
running the same command with translator disabled results in an EXTERNAL
table which is also bad...
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
##########
@@ -22,7 +22,6 @@
import static
org.apache.hadoop.hive.conf.HiveConf.ConfVars.DYNAMICPARTITIONCONVERT;
import static
org.apache.hadoop.hive.conf.HiveConf.ConfVars.HIVE_DEFAULT_STORAGE_HANDLER;
import static org.apache.hadoop.hive.conf.HiveConf.ConfVars.HIVESTATSDBCLASS;
-import static
org.apache.hadoop.hive.metastore.api.hive_metastoreConstants.TABLE_IS_CTAS;
Review comment:
could you please change the summary of the PR to something which makes
more sense than "Revert HIVE-24625 and update task compiler code to set ta"
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
##########
@@ -13137,13 +13136,12 @@ private void updateDefaultTblProps(Map<String,
String> source, Map<String, Strin
*
* @param tblProp
* property map
- * @param isCTAS
* @return Modified table property map
Review comment:
running `create table b2 as select 1 aa` while the translator is
disabled doesnt uncover exceptions ; however it results in an EXTERNAL table
which is also bad...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
