abstractdog commented on a change in pull request #2477:
URL: https://github.com/apache/hive/pull/2477#discussion_r674674240
##########
File path: ql/src/test/queries/clientpositive/create_table.q
##########
@@ -0,0 +1,5 @@
+set hive.support.concurrency=true;
+set hive.txn.manager=org.apache.hadoop.hive.ql.lockmgr.DbTxnManager;
+set hive.create.as.external.legacy=true;
+create managed table test as select 1;
+show create table test;
Review comment:
could you please add
1. "describe formatted test" to this test case also?
2. your expectation in a comment (before show create table)?
3. a "create table" without managed keyword to confirm that in case of
hive.create.as.external.legacy=true, a non-acid managed table will be created
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
