jshmchenxi commented on a change in pull request #2500:
URL: https://github.com/apache/hive/pull/2500#discussion_r674732170



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/ConditionalTask.java
##########
@@ -32,6 +33,8 @@
 public class ConditionalTask extends Task<ConditionalWork> implements 
Serializable {
 
   private static final long serialVersionUID = 1L;
+  private static final ReentrantLock RESOLVE_TASK_LOCK = new ReentrantLock();

Review comment:
       I think that's nice! And we may just use `Task.queryState` instead of 
accessing `queryStateMap`?
   I put the lock in session level because in our use case we seldom run 
queries in parallel within one session.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to