abstractdog commented on a change in pull request #2319:
URL: https://github.com/apache/hive/pull/2319#discussion_r674823717
##########
File path: jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java
##########
@@ -353,7 +353,11 @@ protected HiveConnection(String uri, Properties info,
}
if (isEmbeddedMode) {
client = EmbeddedCLIServicePortal.get(connParams.getHiveConfs());
+ String sessionId =
connParams.getHiveConfs().get(HiveConf.ConfVars.HIVESESSIONID.varname);
Review comment:
this part seems to be hacky, original code made a client from the confs
then cleared the conf, now we're forcing the sessionId to be present in the
hive confs after clearing, why is it?
this way we'll have an almost empty connParams.getHiveConfs(), having only
session id
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
