abstractdog commented on a change in pull request #2225: URL: https://github.com/apache/hive/pull/2225#discussion_r680949949
########## File path: ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/ValueBoundaryScanner.java ########## @@ -664,6 +632,87 @@ public Object computeValue(Object row) throws HiveException { */ public abstract boolean isEqual(Object v1, Object v2); + protected int binarySearchBack(int r, PTFPartition p, Object sortKey, int amt, + Order order) throws HiveException { + boolean isOrderDesc = order.equals(Order.DESC); + Object rowVal = sortKey; + + int rMin = -1; // tracks lowest possible number fulfilling the range requirement Review comment: okay, seems to work -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org