kgyrtkirk commented on a change in pull request #2441:
URL: https://github.com/apache/hive/pull/2441#discussion_r682695432
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/RetryingHMSHandler.java
##########
@@ -61,6 +66,7 @@ public Result(Object result, int numRetries) {
private final Configuration origConf; // base configuration
private final Configuration activeConf; // active configuration
+ private final List<MetaStoreEndFunctionListener> endFunctionListeners; //
the end function listener
Review comment:
didn't know we had something like this :)
but having only `MetaStoreEndFunctionListener` seems a bit odd;
how about:
* introduce a `MetaStoreFunctionListener`
* keep the `MetaStoreEndFunctionListener` interface but extend the new
interface with default implementation of `startFunction`
* move the old logging/counting stuff into a `MetaStoreFunctionListener`
just an idea; let me know what you think!
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/RetryingHMSHandler.java
##########
@@ -202,6 +215,8 @@ public Result invokeInternal(final Object proxy, final
Method method, final Obje
LOG.error(ExceptionUtils.getStackTrace(e.getCause()));
throw e.getCause();
}
+ } finally {
+ endFunction(method, object, ex, args);
Review comment:
I think we could place the `startFunctions` here as well - now we have 1
part here and the other there...
I don't think we will break much things if we do that - or do you think that
could cause some trouble?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
