marton-bod commented on a change in pull request #2427:
URL: https://github.com/apache/hive/pull/2427#discussion_r684017511
##########
File path:
iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerWithEngine.java
##########
@@ -2420,11 +2464,36 @@ private String timestampAfterSnapshot(Table table, int
snapshotPosition) {
return simpleDateFormat.format(new Date(time));
}
- private void checkColStat(String tableName, String colName) {
+ private void checkColStat(String tableName, String colName, boolean
accurate) {
List<Object[]> rows = shell.executeStatement("DESCRIBE " + tableName + " "
+ colName);
Assert.assertEquals(2, rows.size());
Assert.assertEquals(StatsSetupConst.COLUMN_STATS_ACCURATE, rows.get(1)[0]);
+ Assert.assertEquals(accurate,
!rows.get(1)[1].toString().matches("\\{\\}\\s*"));
Review comment:
Can you add a small comment explaining the regex here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
