dantongdong commented on a change in pull request #2559:
URL: https://github.com/apache/hive/pull/2559#discussion_r685495290
##########
File path: itests/qtest/pom.xml
##########
@@ -477,6 +477,23 @@
</profiles>
<build>
<plugins>
+ <plugin>
+ <groupId>com.googlecode.maven-download-plugin</groupId>
+ <artifactId>download-maven-plugin</artifactId>
+ <version>1.3.0</version>
+ <executions>
+ <execution>
+ <phase>generate-sources</phase>
+ <goals>
+ <goal>wget</goal>
+ </goals>
+ <configuration>
+
<url>http://downloads.mariadb.com/Connectors/java/connector-java-2.2.0/mariadb-java-client-2.2.0.jar</url>
+ <outputFileName>mariadb-java-client-2.2.0.jar</outputFileName>
Review comment:
My main concern for using a place holder instead of hard-code is we have
the wget url, I am afraid that different version may have complication around
the wget url pattern? right now hive metastore init test is also using the
hard-coded version for that reason. So I think it may be better to leave it as
it is for now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
