kasakrisz commented on a change in pull request #2568:
URL: https://github.com/apache/hive/pull/2568#discussion_r694551954
##########
File path: ql/src/test/queries/clientpositive/merge_partitioned_insert.q
##########
@@ -0,0 +1,19 @@
+--! qt:transactional
+
+drop table u;
+drop table t;
Review comment:
I haven't found where is table `t` created but `t1` and `t2`.
##########
File path: ql/src/test/queries/clientpositive/merge_partitioned_insert.q
##########
@@ -0,0 +1,19 @@
+--! qt:transactional
+
+drop table u;
+drop table t;
+
+create table u(id integer);
+insert into u values(3);
+
+create table t1(id integer, value string default 'def');
+insert into t1 values(1,'xx');
+insert into t1 (id) values(2);
+
+merge into t1 t using u on t.id=u.id when not matched then insert (id) values
(u.id);
+
Review comment:
Do we have tests that checks the content of the target table after merge
like `select * from t1` ?
##########
File path: ql/src/test/queries/clientpositive/merge_partitioned_insert.q
##########
@@ -0,0 +1,19 @@
+--! qt:transactional
+
+drop table u;
+drop table t;
+
+create table u(id integer);
+insert into u values(3);
+
+create table t1(id integer, value string default 'def');
+insert into t1 values(1,'xx');
+insert into t1 (id) values(2);
+
+merge into t1 t using u on t.id=u.id when not matched then insert (id) values
(u.id);
Review comment:
Adding `explain merge into t1 t using u on t.id=u.id when not matched
then insert (id) values (u.id);` would help checking the right plan is
generated. Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
