dengzhhu653 commented on a change in pull request #2344:
URL: https://github.com/apache/hive/pull/2344#discussion_r705251148
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java
##########
@@ -1850,8 +1819,6 @@ private long partsFoundForPartitions(
}
Deadline.checkTimeout();
}
- } catch (Exception e) {
- throwMetaOrRuntimeException(e);
Review comment:
The exception handling has aready happened in the caller, it's allowing
to throw MetaException or RuntimeException.
The catch-clause is to catch the exception of releasing query with
try-with-resources, as it throws the `Exception`, which should be transformed
to `MetaException` or `RuntimeException`. This is what the `QueryWrapper` wants
to solve, we do not need this after the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
