marton-bod commented on a change in pull request #2644:
URL: https://github.com/apache/hive/pull/2644#discussion_r709874475
##########
File path:
iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/HiveIcebergTestUtils.java
##########
@@ -299,4 +311,68 @@ public static void validateDataWithSQL(TestHiveShell
shell, String tableName, Li
}
}
}
+
+ /**
+ * @param table The table to create the delete file for
+ * @param deleteFilePath The path where the delete file should be created,
relative to the table location root
+ * @param equalityFields List of field names that should play a role in the
equality check
+ * @param fileFormat The file format that should be used for writing out the
delete file
+ * @param rowsToDelete The rows that should be deleted. It's enough to fill
out the fields that are relevant for the
+ * equality check, as listed in equalityFields, the rest
of the fields are ignored
+ * @return The DeleteFile created
+ * @throws IOException If there is an error during DeleteFile write
+ */
+ public static DeleteFile createEqualityDeleteFile(Table table, String
deleteFilePath, List<String> equalityFields,
Review comment:
I think I'm covering that by leaving the last_name field as null,
passing this in:
`add(1L, "Bob", null)`
i.e. not filling out the irrelevant fields.
Or is there something different you're looking for?
##########
File path:
iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/TestHelper.java
##########
@@ -74,8 +82,10 @@ public Table table() {
}
public Map<String, String> properties() {
- return ImmutableMap.of(TableProperties.DEFAULT_FILE_FORMAT,
fileFormat.name(),
- TableProperties.ENGINE_HIVE_ENABLED, "true");
+ Map<String, String> props = new HashMap<>(tblProps);
Review comment:
Sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
