pkumarsinha commented on a change in pull request #2650:
URL: https://github.com/apache/hive/pull/2650#discussion_r711889438
##########
File path:
shims/0.23/src/main/test/org/apache/hadoop/hive/shims/TestHadoop23Shims.java
##########
@@ -94,6 +97,26 @@ public void testConstructDistCpParams() {
}
+ @Test
Review comment:
Also add test for other non supported FS.
##########
File path:
shims/0.23/src/main/java/org/apache/hadoop/hive/shims/Hadoop23Shims.java
##########
@@ -277,6 +277,16 @@ private boolean isFairScheduler (Configuration conf) {
equalsIgnoreCase(conf.get(YarnConfiguration.RM_SCHEDULER));
}
+ private boolean checkFileSystemXAttrSupport(FileSystem fs) {
+ try {
+ fs.getXAttrs(new Path(Path.SEPARATOR));
+ } catch (Exception e) {
+ LOG.warn("XAttr won't be preserved since it is not supported for file
system: " + fs.getUri());
+ return false;
Review comment:
Any exception can't be concluded this way. It could give you wrong
results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
