HarshitGupta11 commented on a change in pull request #2636:
URL: https://github.com/apache/hive/pull/2636#discussion_r712872960
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java
##########
@@ -2197,18 +2199,26 @@ private void
updatePartitionColumnStatisticsInCache(ColumnStatistics colStats, M
sharedCache.updatePartitionColStatsInCache(catName, dbName, tblName,
partVals, colStats.getStatsObj());
}
- @Override public Map<String, String>
updatePartitionColumnStatistics(ColumnStatistics colStats, List<String>
partVals,
+ @Override
+ public Map<String, String> updatePartitionColumnStatistics(Table table,
+ ColumnStatistics colStats, List<String> partVals,
String validWriteIds, long writeId)
throws NoSuchObjectException, MetaException, InvalidObjectException,
InvalidInputException {
Map<String, String> newParams =
- rawStore.updatePartitionColumnStatistics(colStats, partVals,
validWriteIds, writeId);
+ rawStore.updatePartitionColumnStatistics(table, colStats, partVals,
validWriteIds, writeId);
// in case of event based cache update, cache is updated during commit txn
if (newParams != null && !canUseEvents) {
updatePartitionColumnStatisticsInCache(colStats, newParams, partVals);
}
return newParams;
}
+ @Override public Map<String, String>
updatePartitionColumnStatistics(ColumnStatistics statsObj, List<String>
partVals,
+ String validWriteIds, long writeId)
+ throws NoSuchObjectException, MetaException, InvalidObjectException,
InvalidInputException {
+ return updatePartitionColumnStatistics(null, statsObj, partVals,
validWriteIds, writeId);
Review comment:
There were some unit tests that were breaking that used the function
signature without the table. So, I added the additional function in the
interface and routed the original one back to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
