abstractdog commented on a change in pull request #2667:
URL: https://github.com/apache/hive/pull/2667#discussion_r716650055
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/ptf/VectorPTFOperator.java
##########
@@ -318,6 +318,7 @@ protected void initializeOp(Configuration hconf) throws
HiveException {
currentPartitionIntervalDayTimes = new
HiveIntervalDayTime[partitionKeyCount];
VectorExpression.doTransientInit(partitionExpressions, hconf);
+ VectorExpression.doTransientInit(orderExpressions, hconf);
Review comment:
could you please move doTransientInit calls to the beginning of the
method, after super.initializeOp?
I don't think it will change behavior but I can see every vectorized
operator that calls this method, calls at the beginning of initializeOp, I
would try to stay aligned with the pattern :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
