ayushtkn commented on a change in pull request #2655:
URL: https://github.com/apache/hive/pull/2655#discussion_r717329217
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/CopyUtils.java
##########
@@ -65,6 +65,8 @@
private final String copyAsUser;
private FileSystem destinationFs;
private final int maxParallelCopyTask;
+ @VisibleForTesting
Review comment:
Functionality wise, I think NO. It is for the devs most probably.
#Copied ->
The point of an annotation is that its convention and could be used in
static code analysis, whereas a simple comment could not.
It serves the same purpose as the normal annotations like LimitedPrivate,The
InterfaceStability ones....
##########
File path:
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenariosIncrementalLoadAcidTables.java
##########
@@ -243,6 +248,64 @@ public void testReplCM() throws Throwable {
Lists.newArrayList(result, result));
}
+ @Test
+ public void testReplCommitTransactionOnSourceDeleteORC() throws Throwable {
+ // Run test with ORC format & with transactional true.
+ testReplCommitTransactionOnSourceDelete("STORED AS ORC",
"'transactional'='true'");
+ }
+
+ @Test
+ public void testReplCommitTransactionOnSourceDeleteText() throws Throwable {
+ // Run test with TEXT format & with transactional true.
Review comment:
Yeps, Thanx Corrected
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/CopyUtils.java
##########
@@ -401,6 +404,18 @@ private boolean isSourceFileMismatch(FileSystem sourceFs,
ReplChangeManager.File
return false;
}
+ @VisibleForTesting
+ private void runTestOnlyExecutions() throws IOException {
Review comment:
Yahh, My first try was to do so, I thought of using PowerMock, But
MiniDfs has issue with it. Which is part of Hadoop, We can't bother that.
The most I could pull out is a Callable into the test. So to avoid the
delete or FS operations here, and in case in future that can be used later as
well. Let me know if there is any other way out. :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
