warriersruthi commented on a change in pull request #2689:
URL: https://github.com/apache/hive/pull/2689#discussion_r719997573
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/io/arrow/ArrowColumnarBatchSerDe.java
##########
@@ -170,7 +171,7 @@ private static Field toField(String name, TypeInfo
typeInfo) {
for (int i = 0; i < structSize; i++) {
structFields.add(toField(fieldNames.get(i), fieldTypeInfos.get(i)));
}
- return new Field(name, FieldType.nullable(MinorType.STRUCT.getType()),
structFields);
+ return new Field(name, new FieldType(false, new ArrowType.Struct(),
null), structFields);
Review comment:
For the map type, as the key type should be non-nullable, it's required
to keep the struct as non-nullable. The list does not care about its element's
type to be nullable/non-nullable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
