marton-bod commented on a change in pull request #2696:
URL: https://github.com/apache/hive/pull/2696#discussion_r720709682
##########
File path:
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java
##########
@@ -234,16 +240,16 @@ public void
preAlterTable(org.apache.hadoop.hive.metastore.api.Table hmsTable, E
icebergTable = IcebergTableUtil.getTable(conf, catalogProperties);
} catch (NoSuchTableException nte) {
context.getProperties().put(MIGRATE_HIVE_TO_ICEBERG, "true");
- // If the iceberg table does not exist, and the hms table is external
and not temporary and not acid
- // we will create it in commitAlterTable
- StorageDescriptor sd = hmsTable.getSd();
- canMigrateHiveTable = MetaStoreUtils.isExternalTable(hmsTable) &&
!hmsTable.isTemporary() &&
- !AcidUtils.isTransactionalTable(hmsTable);
- if (!canMigrateHiveTable) {
- throw new MetaException("Converting non-external, temporary or
transactional hive table to iceberg " +
- "table is not allowed.");
- }
+ // If the iceberg table does not exist, and the hms table is:
+ // - external
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
