pgaref commented on a change in pull request #2639:
URL: https://github.com/apache/hive/pull/2639#discussion_r723550703
##########
File path:
ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcFileStripeMergeRecordReader.java
##########
@@ -34,7 +35,7 @@
public class TestOrcFileStripeMergeRecordReader {
- private final int DEFAULT_STRIPE_SIZE = 5000;
+ private static final int DEFAULT_STRIPE_SIZE = 5000;
Review comment:
Out of the context of this ticket but: DEFAULT_STRIPE_SIZE seems a bit
low to me.
We are currently using 64k as default in ORC:
https://github.com/apache/orc/blob/main/java/core/src/java/org/apache/orc/OrcConf.java#L30
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
