pvary commented on a change in pull request #2715:
URL: https://github.com/apache/hive/pull/2715#discussion_r727303639
##########
File path:
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergSerDe.java
##########
@@ -231,44 +223,28 @@ public ObjectInspector getObjectInspector() {
/**
* Gets the hive schema from the serDeProperties, and throws an exception if
it is not provided. In the later case
* it adds the previousException as a root cause.
- * @param serDeProperties The source of the hive schema
* @param previousException If we had an exception previously
* @param autoConversion When <code>true</code>, convert unsupported types
to more permissive ones, like tinyint to
* int
* @return The hive schema parsed from the serDeProperties
* @throws SerDeException If there is no schema information in the
serDeProperties
*/
- private static Schema hiveSchemaOrThrow(Properties serDeProperties,
Exception previousException,
- boolean autoConversion)
+ private Schema hiveSchemaOrThrow(Exception previousException, boolean
autoConversion)
throws SerDeException {
- // Read the configuration parameters
- String columnNames =
serDeProperties.getProperty(serdeConstants.LIST_COLUMNS);
- String columnTypes =
serDeProperties.getProperty(serdeConstants.LIST_COLUMN_TYPES);
- // No constant for column comments and column comments delimiter.
- String columnComments = serDeProperties.getProperty(LIST_COLUMN_COMMENT);
- String columnNameDelimiter =
serDeProperties.containsKey(serdeConstants.COLUMN_NAME_DELIMITER) ?
- serDeProperties.getProperty(serdeConstants.COLUMN_NAME_DELIMITER) :
String.valueOf(SerDeUtils.COMMA);
- if (columnNames != null && columnTypes != null && columnNameDelimiter !=
null &&
- !columnNames.isEmpty() && !columnTypes.isEmpty() &&
!columnNameDelimiter.isEmpty()) {
- // Parse the configuration parameters
- List<String> names = new ArrayList<>();
- Collections.addAll(names, columnNames.split(columnNameDelimiter));
- // check if there are partition columns as well
- String partColNames =
serDeProperties.getProperty(serdeConstants.LIST_PARTITION_COLUMNS);
- if (partColNames != null && !partColNames.isEmpty()) {
- // add partition col names to regular col names
- String partColDelimiter =
partColNames.contains(String.valueOf(ColumnType.COLUMN_COMMENTS_DELIMITER)) ?
- String.valueOf(ColumnType.COLUMN_COMMENTS_DELIMITER) :
String.valueOf(SerDeUtils.COMMA);
- Collections.addAll(names, partColNames.split(partColDelimiter));
- // add partition col types to regular col types
- columnTypes += SerDeUtils.COLON +
serDeProperties.getProperty(serdeConstants.LIST_PARTITION_COLUMN_TYPES);
- }
- List<String> comments = new ArrayList<>();
- if (columnComments != null) {
- Collections.addAll(comments,
columnComments.split(Character.toString(Character.MIN_VALUE)));
- }
- Schema hiveSchema = HiveSchemaUtil.convert(names,
TypeInfoUtils.getTypeInfosFromTypeString(columnTypes),
- comments, autoConversion);
+ List<String> names = Lists.newArrayList();
Review comment:
Thx 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
