aasha commented on a change in pull request #2724:
URL: https://github.com/apache/hive/pull/2724#discussion_r733658593



##########
File path: 
standalone-metastore/metastore-server/src/main/sql/derby/upgrade-3.2.0-to-4.0.0.derby.sql
##########
@@ -98,7 +98,7 @@ CREATE TABLE "APP"."REPLICATION_METRICS" (
 );
 
 --Increase the size of RM_PROGRESS to accomodate the replication statistics
-ALTER TABLE "APP"."REPLICATION_METRICS" ALTER "RM_PROGRESS" SET DATA TYPE 
VARCHAR(24000);
+ALTER TABLE "APP"."REPLICATION_METRICS" ALTER "RM_PROGRESS" SET DATA TYPE 
VARCHAR(10000);

Review comment:
       dont modify this. Do a alter table and reduce the size.

##########
File path: 
standalone-metastore/metastore-server/src/main/sql/mysql/hive-schema-4.0.0.mysql.sql
##########
@@ -1269,7 +1269,7 @@ CREATE TABLE IF NOT EXISTS REPLICATION_METRICS (
   RM_POLICY varchar(256) NOT NULL,
   RM_DUMP_EXECUTION_ID bigint NOT NULL,
   RM_METADATA varchar(4000),
-  RM_PROGRESS varchar(24000),
+  RM_PROGRESS varchar(10000),

Review comment:
       dont modify this. Do a alter table and reduce the size.

##########
File path: 
standalone-metastore/metastore-server/src/main/sql/mysql/upgrade-3.2.0-to-4.0.0.mysql.sql
##########
@@ -105,7 +105,7 @@ CREATE TABLE IF NOT EXISTS REPLICATION_METRICS (
 ) ENGINE=InnoDB DEFAULT CHARSET=latin1;
 
 --Increase the size of RM_PROGRESS to accomodate the replication statistics
-ALTER TABLE REPLICATION_METRICS MODIFY RM_PROGRESS varchar(24000);
+ALTER TABLE REPLICATION_METRICS MODIFY RM_PROGRESS varchar(10000);

Review comment:
       dont modify this. Do a alter table and reduce the size.

##########
File path: 
standalone-metastore/metastore-server/src/main/sql/postgres/hive-schema-4.0.0.postgres.sql
##########
@@ -1976,7 +1976,7 @@ CREATE TABLE "REPLICATION_METRICS" (
   "RM_POLICY" varchar(256) NOT NULL,
   "RM_DUMP_EXECUTION_ID" bigint NOT NULL,
   "RM_METADATA" varchar(4000),
-  "RM_PROGRESS" varchar(24000),
+  "RM_PROGRESS" varchar(10000),

Review comment:
       dont modify this. Do a alter table and reduce the size.

##########
File path: 
standalone-metastore/metastore-server/src/main/sql/postgres/upgrade-3.2.0-to-4.0.0.postgres.sql
##########
@@ -229,7 +229,7 @@ CREATE TABLE "REPLICATION_METRICS" (
 );
 
 --Increase the size of RM_PROGRESS to accomodate the replication statistics
-ALTER TABLE "REPLICATION_METRICS" ALTER "RM_PROGRESS" TYPE varchar(24000);
+ALTER TABLE "REPLICATION_METRICS" ALTER "RM_PROGRESS" TYPE varchar(10000);

Review comment:
       dont modify this. Do a alter table and reduce the size.

##########
File path: 
standalone-metastore/metastore-server/src/test/resources/sql/postgres/upgrade-3.1.3000-to-4.0.0.postgres.sql
##########
@@ -49,7 +49,7 @@ CREATE TABLE "REPLICATION_METRICS" (
     );
 
 --Increase the size of RM_PROGRESS to accomodate the replication statistics
-ALTER TABLE "REPLICATION_METRICS" ALTER "RM_PROGRESS" TYPE varchar(24000);
+ALTER TABLE "REPLICATION_METRICS" ALTER "RM_PROGRESS" TYPE varchar(10000);

Review comment:
       dont modify this. Do a alter table and reduce the size.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to