zabetak opened a new pull request #2742: URL: https://github.com/apache/hive/pull/2742
### What changes were proposed in this pull request? 1. Refactor `AbstractExternalDB` and subclasses: (i) turn setters to getters; (ii) inline methods; (iii) reduce visibility when possible; (iv) drop redundant comments; (v) drop unnecessary logging and try/catch blocks. 2. Use provided user/password/dbname when starting Postgres instead of default. 3. Use correct driver and docker image for MySQL database. 4. Support additional databases (MariaDB, Oracle, MSSQLServer) for tests. 5. Introduce `QTestDatabaseHandler` class for handling completely setup, init and cleanup of dockerized DBMS. 6. Drop `TestMiniLlapExtDBCliDriver`, with associated config, properties etc. ### Why are the changes needed? It is now possible to: 1. initialize a dockerized DBMS in any qtest without the need for specific CLI driver or configuration; 2. use multiple DBMS of different types in the same qtest; 3. use different initialization scripts per test/database; 4. use additional databases (MariaDB, Oracle, MSSQLServer) in tests. Misc: 5. Improve readability and encapsulation of `AbstractExternalDB` and friends. 6. Small bugs in Postgres and MySQL. ### Does this PR introduce _any_ user-facing change? No, it only impacts developers. ### How was this patch tested? `mvn test -Dtest=TestMiniLlapLocalCliDriver -Dqfile_regex="qt_database.*" -Dtest.output.overwrite` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
