zabetak opened a new pull request #2759: URL: https://github.com/apache/hive/pull/2759
The tests rely on HIVE-25594 for which there is a separate pull request (https://github.com/apache/hive/pull/2742). Please do not review https://github.com/apache/hive/commit/cb3026b4db9454c12d5376c71a28eb34b35d783d here. If there are remarks please comment on https://github.com/apache/hive/pull/2742 instead. ### What changes were proposed in this pull request? 1. Remove getOriQueryToExecute method in favor of getQueryToExecute 2. Move getQueryToExecute method into GenericJdbcDatabaseAccessor to improve encapsulation since the method is only used in this class. 3. Include hive.sql.schema if available when generating the SQL query. 4. Add tests/usage samples of hive.sql.schema property in different DBMS. ### Why are the changes needed? 1. Avoid failures when the table is in non-default schema. 2. Demonstrate how hive.sql.schema can be used in different DBMS. 3. Minor encapsulation improvement. ### Does this PR introduce _any_ user-facing change? Fixes a failure. ### How was this patch tested? `mvn test -Dtest=TestMiniLlapLocalCliDriver -Dqfile_regex="jdbc_table_with_schema.*" -Dtest.output.overwrite` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
