pvary commented on a change in pull request #2750:
URL: https://github.com/apache/hive/pull/2750#discussion_r742721728



##########
File path: 
ql/src/java/org/apache/hadoop/hive/ql/io/LlapCacheOnlyInputFormatInterface.java
##########
@@ -25,4 +25,11 @@
 /** Marker interface for LLAP IO. */
 public interface LlapCacheOnlyInputFormatInterface {
   void injectCaches(FileMetadataCache metadataCache, DataCache dataCache, 
Configuration cacheConf);
+
+  /**
+   * For inputformats that can only accept LLAP caching with vectorization 
turned on.
+   */
+  interface VectorizedOnly extends LlapCacheOnlyInputFormatInterface {

Review comment:
       Why do we need vectorization turned on for LLAP caching

##########
File path: 
ql/src/java/org/apache/hadoop/hive/ql/io/LlapCacheOnlyInputFormatInterface.java
##########
@@ -25,4 +25,11 @@
 /** Marker interface for LLAP IO. */
 public interface LlapCacheOnlyInputFormatInterface {
   void injectCaches(FileMetadataCache metadataCache, DataCache dataCache, 
Configuration cacheConf);
+
+  /**
+   * For inputformats that can only accept LLAP caching with vectorization 
turned on.
+   */
+  interface VectorizedOnly extends LlapCacheOnlyInputFormatInterface {

Review comment:
       Why do we need vectorization turned on for LLAP caching?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to