klcopp commented on a change in pull request #2741:
URL: https://github.com/apache/hive/pull/2741#discussion_r744857505
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java
##########
@@ -508,14 +540,6 @@ private boolean isEligibleForCompaction(CompactionInfo ci,
return false;
}
- if (txnHandler.checkFailedCompactions(ci)) {
Review comment:
Can remove
org.apache.hadoop.hive.metastore.txn.CompactionTxnHandler#checkFailedCompactions
(it is now only called by unit tests)
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java
##########
@@ -474,9 +508,7 @@ private boolean isEligibleForCompaction(CompactionInfo ci,
// as it may be time to compact again even though we haven't cleaned.
// todo: this is not robust. You can easily run `alter table` to start a
compaction between
// the time currentCompactions is generated and now
Review comment:
Maybe add another comment here about what "failed compactions" means
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
