kgyrtkirk commented on a change in pull request #1674:
URL: https://github.com/apache/hive/pull/1674#discussion_r750213025
##########
File path: service/lib/php/ext/thrift_protocol/php_thrift_protocol.cpp
##########
@@ -429,7 +429,7 @@ void binary_deserialize(int8_t thrift_typeID,
PHPInputTransport& transport, zval
throw_tprotocolexception(errbuf, INVALID_DATA);
RETURN_NULL();
}
- binary_deserialize_spec(return_value, transport, Z_ARRVAL_P(spec));
+ binary_deserialize_spec(return_value, transport, Z_ARRIVAL_P(spec));
Review comment:
have you regenerated the thrift interfaces? I'm not sure if this is
coming from Hive
##########
File path: ql/src/test/queries/clientnegative/dyn_part_empty.q.disabled
##########
@@ -15,7 +15,7 @@
-- limitations under the License.
set hive.exec.dynamic.partition=true;
-set hive.stats.autogether=false;
+set hive.stats.autogather=false;
Review comment:
lol!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
